Skip to content

Conversation

@gmmcosta15
Copy link
Collaborator

@gmmcosta15 gmmcosta15 commented Dec 18, 2025

What Changed?

/lib/panels/widgets/tunePage.py

  • Only controllable fans are shown to the user.
  • The three icon types (blower.svg, fan_cage.svg, fan.svg) are loaded once to improve performance.
  • A regex-based approach is used to differentiate between fan types:
    • fan.svg is the default icon.
    • blower.svg is used when the fan's name matches *_blower|auxiliary_*.
    • fan_cage.svg is used when the fan's name matches *_exhaust_*.

/lib/ui/resources/icon_resources.qrc

  • blower.svg now is under the fan_related prefix.

Screenshots

Before

Captura de ecrã 2025-12-18 103205

After

Captura de ecrã 2025-12-18 103640

Future Work

  • Unit and Integration Tests.

Guilherme Costa and others added 3 commits December 15, 2025 16:27
@gmmcosta15 gmmcosta15 requested a review from HugoCLSC December 18, 2025 10:50
@gmmcosta15 gmmcosta15 self-assigned this Dec 18, 2025
@gmmcosta15 gmmcosta15 added bug Something isn't working UI/UX User Interface what changed with this code labels Dec 18, 2025
@gmmcosta15 gmmcosta15 marked this pull request as ready for review December 18, 2025 11:45
@gmmcosta15 gmmcosta15 changed the title Add clickability and distinct icons to controllable fans Bugfix ´tunePage´: Add clickability and distinct icons to controllable fans Dec 18, 2025
@gmmcosta15 gmmcosta15 changed the title Bugfix ´tunePage´: Add clickability and distinct icons to controllable fans Bugfix tunePage: Add clickability and distinct icons to controllable fans Dec 18, 2025
@gmmcosta15 gmmcosta15 closed this Dec 18, 2025
@gmmcosta15 gmmcosta15 reopened this Dec 18, 2025
@HugoCLSC HugoCLSC merged commit db29de9 into dev Jan 2, 2026
7 of 8 checks passed
@HugoCLSC HugoCLSC deleted the bugfix/fans-button-not-clickable branch January 2, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI/UX User Interface what changed with this code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants